Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(appveyor): fix pyinstaller #4494

Merged
merged 3 commits into from
Dec 15, 2023
Merged

ci(appveyor): fix pyinstaller #4494

merged 3 commits into from
Dec 15, 2023

Conversation

syu-w
Copy link
Contributor

@syu-w syu-w commented Dec 12, 2023

@syu-w syu-w force-pushed the work/fix-new-pyinstall branch 4 times, most recently from e54cee4 to 351f930 Compare December 13, 2023 15:34
@syu-w syu-w marked this pull request as ready for review December 13, 2023 20:28
@syu-w syu-w requested review from mr-cal and lengau December 13, 2023 20:28
lengau
lengau requested changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Please update tools/freeze-requirements.sh for this too

@syu-w syu-w requested a review from lengau December 14, 2023 13:33
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6300e0e) 89.20% compared to head (ba08b9c) 89.20%.
Report is 1 commits behind head on main.

❗ Current head ba08b9c differs from pull request most recent head c21a4d3. Consider uploading reports for the commit c21a4d3 to get more accurate results

Files Patch % Lines
snapcraft_legacy/internal/dirs.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4494   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files         322      322           
  Lines       21773    21773           
=======================================
  Hits        19423    19423           
  Misses       2350     2350

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syu-w syu-w force-pushed the work/fix-new-pyinstall branch from 84064dd to ba08b9c Compare December 14, 2023 19:25
mr-cal
mr-cal approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lengau lengau mentioned this pull request Dec 15, 2023
Closed
1 task
@mr-cal mr-cal merged commit a763c54 into main Dec 15, 2023
@Porkepix Porkepix mentioned this pull request Jan 3, 2024
Merged
1 task
syu-w added a commit that referenced this pull request Jan 29, 2024
@syu-w
ci(appveyor): fix pyinstaller (#4494)
cfdb71c 
Addresses CVE-2023-49797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syu-w @codecov-commenter @lengau @mr-cal